Bug 11709 - Make it static context action is too broad
Summary: Make it static context action is too broad
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: unspecified
Hardware: PC Mac OS
: Normal normal
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2013-04-10 13:54 UTC by Mikayla Hutchinson [MSFT]
Modified: 2013-05-02 05:55 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2013-04-10 13:54:06 UTC
The "Make it static" context action is shows for entire methods. It's not clear that it refers to the method rather than not the things within the method. It should probably only be shown on the method name and modifiers, and renamed to "Make method static".
Comment 1 Mike Krüger 2013-04-11 05:45:48 UTC
in fact it shouldn't be a context action - Ciprian Khlud converts that to a code issue.
He needed first to look at the code issue API etc.
Comment 2 Ciprian Khlud 2013-04-16 11:00:18 UTC
Fixed: https://github.com/ciplogic/NRefactory/commit/dd8caea759555b18ee88748b8744e746f763940a 

I limited the range from methodDeclaration.Start to methodBody.Start (I am not fully sure the way to get just the name's range).
Comment 3 Mike Krüger 2013-04-19 12:22:27 UTC
Name range is easy:

mothod.NameToken.Start - End
Comment 4 Ciprian Khlud 2013-04-19 14:46:55 UTC
You're right. I've put all in this commit: https://github.com/ciplogic/NRefactory/commit/d225305f0d4d8f7bb0f3156e86b6b103edac84b2
Comment 6 Mike Krüger 2013-05-02 05:55:12 UTC
Thanks