Bug 11567 - ICSharpCode.NRefactory.CSharp/Resolver/ResolveVisitor.cs makes debugger log unusable
Summary: ICSharpCode.NRefactory.CSharp/Resolver/ResolveVisitor.cs makes debugger log u...
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: unspecified
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks: 11535
  Show dependency tree
 
Reported: 2013-04-03 19:49 UTC by Mikayla Hutchinson [MSFT]
Modified: 2013-04-04 13:49 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2013-04-03 19:49:39 UTC
When debugging MD on Mono 3.x (i.e. with working Debugger.Log), ICSharpCode.NRefactory.CSharp/Resolver/ResolveVisitor.cs makes the debugger output window unusable by writing out vast amounts of information including entire files.
Comment 1 Mike Krüger 2013-04-04 01:28:30 UTC
Then compile NRefactory as release version and not as debug.
Comment 2 Mikayla Hutchinson [MSFT] 2013-04-04 01:45:15 UTC
"fixed" in https://github.com/mono/monodevelop/commit/25e9d7d5c53883c397ab83bcf9f2be1afb88de19

I hope you didn't need debug symbols for NRefactory...
Comment 3 Mike Krüger 2013-04-04 01:50:06 UTC
Hm, depends - from time to time I need the debug.log output.
The logging output is from daniel I'll talk with him to maybe use a different logging in nrefactory, but it's nothing we'll do today therefore it's quicker to turn nrefactory debugging off.
Comment 4 Mike Krüger 2013-04-04 01:57:26 UTC
I looked at the nrefactory code - seems a problem in mcs. I've disabled logging in nrefactory now in debug mode.
Comment 5 Mikayla Hutchinson [MSFT] 2013-04-04 13:23:06 UTC
Why do you think it's a problem in mcs?
Comment 6 Mike Krüger 2013-04-04 13:25:37 UTC
The csc version uses a constant to determine if logging is on or off.

Seems not to work in mcs - that's why the logging in mcs was on. I just changed the mcs version. The logging contained some __MonoCS__ #ifdefs.
Comment 7 Mikayla Hutchinson [MSFT] 2013-04-04 13:49:29 UTC
Ah, so mcs wasn't constant folding the expressions in the ConditionalAttribute? You should file a mcs bug...