Bug 11311 - Cmd + S doesn't save file
Summary: Cmd + S doesn't save file
Status: VERIFIED FIXED
Alias: None
Product: Android
Classification: Xamarin
Component: Designer ()
Version: 4.8.x
Hardware: Macintosh Mac OS
: --- normal
Target Milestone: ---
Assignee: Lluis Sanchez
URL:
Depends on:
Blocks:
 
Reported: 2013-03-20 21:12 UTC by bryan costanich
Modified: 2014-01-21 06:32 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description bryan costanich 2013-03-20 21:12:20 UTC
If you're working in the Xamarin Android Designer and make changes, if you hit Cmd+S, the file doesn't save. You have to go up to file > save.
Comment 1 Lluis Sanchez 2013-03-21 04:09:42 UTC
I can't reproduce. Does it always fail or only sometimes? Can you paste the version info from the about box?
Comment 2 bryan costanich 2013-03-21 12:46:54 UTC
i just figured out more info - if you're in the properties pad, e.g., let's say you just edited the control ID, then the commands aren't available in there. i think that's the issue.
Comment 3 Lluis Sanchez 2013-03-21 13:50:58 UTC
Yes, most commands are contextual, they are only enabled when the view to which they apply has the focus. Maybe could make an exception for the Save command, since the only purpose of that command (right now) is to save the currently active view. However, we plan to add support for placing editors side by side (a very demanded feature), and then the save command will have to require an editor to have the focus, since it will be the only way to know which editor the user wants to save.
Comment 4 bryan costanich 2013-03-21 13:54:01 UTC
but that doesn't make sense. the toolbox is part of the editor. it's context is directly wired to whatever view is in focus, yeah? so if i'm editing a control's properties in the toolbox, when i hit save, it should be for that control's file.
Comment 5 Lluis Sanchez 2013-03-21 14:52:15 UTC
I guess you mean the property pad. Yes, that makes sense for the property pad, since as you say it is tied to the designer. I'll fix it.
Comment 6 bryan costanich 2013-03-21 14:54:02 UTC
yeah, that one. sorry. 

yay!
Comment 7 Lluis Sanchez 2013-03-22 09:01:08 UTC
Fixed in master.
Comment 8 Saurabh 2014-01-21 06:32:59 UTC
We have checked this issue with latest master builds:

XS 4.2.3 (build 146) 
Git revision: 76e7c7f6ca0e59052f2bb29f8179313510977377
Xamarin addins: cc120a6f639fa6649aa4d23a0f0e7c5701134047

mono-android-4.13.0-36(Master for Mac)

Now, we are able to save changed made Xamarin Android Designer page by hitting 
Cmd+S.

Screencast: http://screencast.com/t/D1kdzCaYZE

Hence, closing this issue.