Bug 10778 - Strange code folding bindings on Mac
Summary: Strange code folding bindings on Mac
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Text Editor ()
Version: Trunk
Hardware: PC Mac OS
: Low minor
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2013-02-28 15:00 UTC by Bojan Rajkovic [MSFT]
Modified: 2013-03-11 09:28 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Bojan Rajkovic [MSFT] 2013-02-28 15:00:44 UTC
The code folding bindings that come out of the box on Mac don't work until you rebind them. I have Ctrl-Cmd-Left and Ctrl-Shift-Cmd-Right bound to Toggle current fold and Fold all definitions respectively, but neither worked until I manually rebound them.
Comment 1 Mikayla Hutchinson [MSFT] 2013-03-01 17:08:34 UTC
Works for me without rebinding.

FYI fold all definitions is OPT-Shift-Cmd-Right. Maybe you were misreading it?

It does seem weird that fold all definitions is so different, and that it's not a toggle.
Comment 2 Mikayla Hutchinson [MSFT] 2013-03-01 17:31:01 UTC
Okay this is weirdly inconsistent with Xcode.

In Xcode:
fold = opt-cmd-left
unfold = opt-cmd-right

In XS:
toggle = CTRL-cmd-left

So - why did we change opt to ctrl?

Fold all definitions is weirder:

In Xcode:
fold = shift-opt-cmd-left
unfold = shift-opt-cmd-right

In XS:
fold = shift-opt-cmd-right

So the XS fold command is inconsistent with xcode - it has the keybinding of the Xcode UNfold command. And it's inconsistent with XS fold command, since it still uses opt, and isn't a toggle.

I suggest we change "Fold all definitions" to "Toggle all definitions", and have:
toggle = opt-cmd-left
toggle all = shift-opt-cmd-left
Comment 3 Mike Krüger 2013-03-11 09:28:40 UTC
I assume that is because opt-cmd-left was bound to navigate backward.

But that was wrong as well - that should be control-meta-left 
I changed the navigate forward/backward bindings as well. 

/fixed