Bug 10350 - Code Analysis doesn't work properly for enum values with names like RESERVED_1
Summary: Code Analysis doesn't work properly for enum values with names like RESERVED_1
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Text Editor ()
Version: 4.0
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2013-02-17 09:53 UTC by Jeffrey Stedfast
Modified: 2013-07-23 04:20 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Comment 1 Mike Krüger 2013-02-18 07:00:43 UTC
fixed
Comment 2 Mikayla Hutchinson [MSFT] 2013-02-18 18:47:01 UTC
The fix is not correct AFAICT as it will turn things like Net_1_1 into Net11, where they should be turned into Net1_1.
Comment 3 Mike Krüger 2013-02-18 23:44:51 UTC
What does reshaper do with Net_1_1 ?
Comment 4 Mikayla Hutchinson [MSFT] 2013-02-19 02:25:17 UTC
Dunno, but converting "1_1" (which probably meant "1.1") to "11" is nonsensical - 1.1 != 11. That's why I had that check in there.
Comment 5 Mike Krüger 2013-07-23 04:20:59 UTC
Net1_1 is not a name according to .NET naming guidelines. This kind of formatting wasn't specified -  and therefore it's ok to the rules to warn about that.

I checked with R# - they do the same.

For things like that use:

	// Resharper disable InconsistentNaming

.... 

	// Resharper restore InconsistentNaming


And no - we shouldn't change the .NET naming guidelines - there are just some exceptions to the 'golden rules' - that's what issue suppression is for.