Bug 10194 - XElement.SetElementValue doesn't handle the case where the element doesn't exist AND value == null
Summary: XElement.SetElementValue doesn't handle the case where the element doesn't ex...
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: System.XML ()
Version: 2.10.x
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2013-02-09 20:11 UTC by Jahmai
Modified: 2013-08-07 12:37 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Jahmai 2013-02-09 20:11:24 UTC
Calling XElement.SetElementValue with a value of null where the specified element name doesn't currently exist rules in a NullReferenceException.

The code is currently;

using System;
public void SetElementValue(XName name, object value)
{
	XElement xElement = base.Element(name);
	if (xElement == null && value != null)
	{
		base.Add(new XElement(name, value));
	}
	else
	{
		if (xElement != null && value == null)
		{
			xElement.Remove();
		}
		else
		{
			xElement.SetValue(value);
		}
	}
}

The fix is to simple handle where xElement is null in the final brace block.
Comment 1 Atsushi Eno 2013-08-07 12:37:53 UTC
Fixed in git master [3e2f5ef]