Bug 10017 - ItemDefinitionGroup not supported
Summary: ItemDefinitionGroup not supported
Status: NEW
Alias: None
Product: Tools
Classification: Mono
Component: xbuild ()
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2013-02-04 11:08 UTC by Silviu Paragina
Modified: 2015-05-01 15:05 UTC (History)
7 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Original patch posted on the Novell bug tracker, I'm not the author (27.02 KB, patch)
2013-02-04 11:08 UTC, Silviu Paragina
Details
Original patch suitable for revision curent (27.02 KB, application/octet-stream)
2014-05-01 11:18 UTC, konstantinn
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 10017 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Silviu Paragina 2013-02-04 11:08:53 UTC
Created attachment 3327 [details]
Original patch posted on the Novell bug tracker, I'm not the author

This doesn't seem implemented yet in Mono 

My banner versions are:
XBuild Engine Version 3.0.3.0
Mono, Version 3.0.3.0

This was introduced in the Novell bugtracker https://bugzilla.novell.com/show_bug.cgi?id=653590#c0 with a patch.
As it might be easy to integrate I'm reposting the bug here.

Extra note: I have no relation with the original reporter.

Original description:

Tests and implementation for ItemDefinitionGroup support.

<Project>
  <ItemDefinitionGroup>
    <A>
      <Meta>Data</Meta>
    </A>
  </ItemDefinitionGroup>

  <A Include="a" />
</Project>

This is not supported by XBuild. AFAIK this is a MSBuild 3.5 feature.
See attached patch!
Comment 1 Yosy 2014-04-08 12:33:41 UTC
Hi,
I am really interested in this feature!
Will this patch will be accepted to xbuild? If so, when?


Thanks,
Yosy
Comment 2 konstantinn 2014-05-01 11:18:57 UTC
Created attachment 6693 [details]
Original patch suitable for revision curent

It is the patch from the issue made for revision e1d0655aa3bc38361f972183f8843407ddd3a7cc.

Unfortunately it doesn't not fix the issue !
Comment 3 konstantinn 2014-05-01 11:20:54 UTC
Please add support for ItemDefinitionGroup !
It doesn't allow to have one file for build.

Also, Nemerle language compiler uses MSbuild file to compile and this requires to have two files and always synchronize them.
Comment 4 Yuta Sato (lambdalice) 2014-05-06 07:24:22 UTC
I need ItemDefinitionGroup... please implement it.

thanks lambdalice
Comment 5 Mikayla Hutchinson [MSFT] 2014-05-06 19:47:16 UTC
@kontantinn can you please explain what you mean by comment #2. Does the patch not work?
Comment 6 konstantinn 2014-05-06 23:54:44 UTC
I have adapted the patch to the current revision of Mono, but it actually doesn't work.
I have tried to use it and got ArgumentNullException at some point :(
I think there have been a lot of changes in the Mono and that patch requires some changes to be correct.
Unfortunately I don't have time to look on it, so I just put a patch to make life easier in case someone wants to add support for ItemDefinitionGroup.
Comment 7 Greg Najda 2014-08-09 20:48:52 UTC
If you need a use case for this feature, the ANTLR 4 build integration NuGet
package (http://www.nuget.org/packages/Antlr4/) uses an ItemDefinitionGroup.
Comment 8 Nate Cook 2015-05-01 15:05:32 UTC
We also need this feature.